axis: read the program the config opens once the HAL is whole - #4507
Open
grandixximo wants to merge 1 commit into
Open
axis: read the program the config opens once the HAL is whole#4507grandixximo wants to merge 1 commit into
grandixximo wants to merge 1 commit into
Conversation
The interpreter reads HAL pins to preview a program, the parameters of a kinematics module whose geometry lives in HAL among them, and a postgui file connects those after the panels that carry them exist. The program a config opens is read before that, so a machine whose geometry comes from a panel is previewed with the geometry all zeros. Read the program after the postgui file has run instead, in the same step that raises the window.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AXIS reads the program a config opens with
[DISPLAY]OPEN_FILEbefore it runs[HAL]POSTGUI_HALFILE, so the preview is taken while everything the postgui file connects is still at its default.The interpreter reads HAL while it previews, so this matters wherever a postgui file sets limits, pivots, offsets, or the parameters of a kinematics module whose geometry lives in HAL: the preview is of a machine that is not the one the program runs on. The nutating head sims in
configs/sim/axis/vismach/5axis/table-rotary_spindle-rotary-nutatingtake their nutation angle and pivot lengths from panel sliders, and are previewed with all of it at zero.This reads the program after the postgui file has run, in the same step that raises the window, so the order the operator sees does not change. The file open and the view setup it feeds move into
open_initial_file(), called from both the HAL and the no-HAL startup paths.gmoccapy, qtdragon and touchy read their startup program before their postgui as well. If this is accepted I will follow with the same change for them.